Skip to content

Allow inline column check constraint definitions to appear in any order#295

Merged
fulghum merged 2 commits intomainfrom
fulghum/inline-check-position
Dec 20, 2023
Merged

Allow inline column check constraint definitions to appear in any order#295
fulghum merged 2 commits intomainfrom
fulghum/inline-check-position

Conversation

@fulghum
Copy link
Copy Markdown

@fulghum fulghum commented Dec 19, 2023

Previously, an inline column check constraint could only appear as the very last option for a column definition. This change allows it to appear in other positions in the column definition. For example, this query now works:

create table t123 (c1 varchar(5) check (c1 in ('v1', 'v2')) NOT NULL);

Resolves: dolthub/dolt#7195

…order in a column definition, instead of only at the very end
@fulghum fulghum marked this pull request as ready for review December 19, 2023 23:56
@fulghum fulghum requested a review from zachmu as a code owner December 19, 2023 23:56
Copy link
Copy Markdown
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 3729729 into main Dec 20, 2023
@fulghum fulghum deleted the fulghum/inline-check-position branch December 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error parsing CREATE TABLE with both CHECK and NOT NULL

2 participants